Re: [PATCH] x86: clean up setup_clear/force_cpu_cap handling

[Ingo Molnar]

* Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> On Saturday 27 December 2008 20:52:34 Ingo Molnar wrote:
> > 
> > * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> > 
> > > Impact: fix and cleanup
> > > 
> > > setup_force_cpu_cap() only have one user xen
> > > but it should not reuse cleared_cpu_cpus. it will have problem
> > > for smp.
> > > 
> > > need to have cpu_cpus_set array too.
> > > also need to setup handling before all cpus cap AND
> > > 
> > > Signed-off-by: Yinghai Lu <yinghai.lu@xxxxxxxxxx>
> > > 
> > > ---
> > >  arch/x86/include/asm/cpufeature.h |    4 ++--
> > >  arch/x86/include/asm/processor.h  |    3 ++-
> > >  arch/x86/kernel/cpu/common.c      |   17 ++++++++++++-----
> > >  3 files changed, 16 insertions(+), 8 deletions(-)
> > 
> > Rusty, you'll carry this patch in your linux-2.6-boot-params.git tree, 
> > right? Merging this in the x86 tree would just needlessly complicate your 
> > logistics, right?
> 
> Yep, if you're happy to ack, I'm happy to carry.

yeah. And if it breaks, that's your fault ;-)

Acked-by: Ingo Molnar <mingo@xxxxxxx>

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/