Re: x86/mce merge, integration hickup + crash, design thoughts

[Andi Kleen]

Ingo Molnar wrote:

> today i (belatedly ...) started looking into the status of the tip/x86/mce 
> branch, and merged it into tip/master as a first step.
>
> firstly there's a small complication, it triggers this crash with the 
> attached config:

I tested the config on a couple of different systems. Unfortunately I
wasn't able to reproduce the problem. It booted always fine even on multiple
tries.

I had to adapt the configuration slightly to boot in my setup.

The configuration also was not complete, i had
to press return a few times (are you sure you sent me the correct file?)

One merging issue I noted is that you put the perfctrs and mce self
on the same vector. The attached patch fixes that.

-Andi



commit c736d118dcad93929dfc21cb72f33bc94c1b314a
Author: Andi Kleen <ak@xxxxxxxxxxxxxxx>
Date:   Sun Dec 28 14:16:43 2008 +0100

    Avoid conflict of apic error and local perfmon vector
    
    Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

diff --git a/arch/x86/include/asm/irq_vectors.h b/arch/x86/include/asm/irq_vectors.h
index 73957a2..0fcb682 100644
--- a/arch/x86/include/asm/irq_vectors.h
+++ b/arch/x86/include/asm/irq_vectors.h
@@ -88,7 +88,7 @@
 /*
  * Performance monitoring interrupt vector:
  */
-#define LOCAL_PERF_VECTOR	0xee
+#define LOCAL_PERF_VECTOR	0xed
 
 /*
  * First APIC vector available to drivers: (vectors 0x30-0xee) we