Re: [-tip tree] compile error in arch/ia64/kernel/acpi.c

From: Kamalesh Babulal
Date: Wed Dec 31 2008 - 10:20:37 EST


* Rusty Russell <rusty@xxxxxxxxxxxxxxx> [2008-12-31 21:35:08]:

> On Wednesday 31 December 2008 19:46:07 Li Zefan wrote:
> > arch/ia64/kernel/acpi.c:205: error: conflicting types for 'total_cpus'
> > include/linux/smp.h:25: error: previous declaration of 'total_cpus' was here
> >
> > due to [PATCH 3/3] cpumask: add sysfs displays for configured and disabled cpu maps
> > (http://lkml.org/lkml/2008/12/19/25)
>
> Hmm, I don't know how this escaped linux-next. But the fix is simple:
>
Hi Rusty,

This was caught in today's linux-next :)


> Subject: Remove IA64 definition of total_cpus now it's in core code
>
> Impact: fix IA64 compile
>
> Fortunately, they have exactly the same semantics.
>
Tested-by: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>
> diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c
> --- a/arch/ia64/kernel/acpi.c
> +++ b/arch/ia64/kernel/acpi.c
> @@ -202,7 +202,6 @@ char *__init __acpi_map_table(unsigned l
> Boot-time Table Parsing
> -------------------------------------------------------------------------- */
>
> -static int total_cpus __initdata;
> static int available_cpus __initdata;
> struct acpi_table_madt *acpi_madt __initdata;
> static u8 has_8259;

--
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/