Re: [PATCH 01/15] ACPI: create kernel/acpi/

[Sam Ravnborg]

On Wed, Dec 31, 2008 at 03:21:08PM +0100, Andi Kleen wrote:
> Sam Ravnborg <sam@xxxxxxxxxxxx> writes:
> > Why is ACPI_CFLAGS exported?
> >> +ACPI_CFLAGS	:= -Os
> >> +
> >> +ifdef CONFIG_ACPI_DEBUG
> >> +  ACPI_CFLAGS	+= -DACPI_DEBUG_OUTPUT
> >> +endif
> >> +
> >> +EXTRA_CFLAGS	+= $(ACPI_CFLAGS)
> > A better way:
> >
> > ccflags-$(CONFIG_ACPI_DEBUG) := -DACPI_DEBUG_OUTPUT
> 
> Surely s/:=/+=/ ?

Only if ccflags-y is assigned earlier in the same file
otherwise it does not matter.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/