Re: [patch 3/3] acpi: check for pxm_to_node_map overflow

From: Ingo Molnar
Date: Fri Jan 02 2009 - 04:23:54 EST



* Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:

> It is hardly (if ever) possible but in case of broken _PXM
> entry we could reach out of pxm_to_node_map array
> bounds in acpi_map_pxm_to_node() call. Lets check it
> (it's not that expensive and safe).
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
> CC: Len Brown <lenb@xxxxxxxxxx>
> ---
> drivers/acpi/numa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

just curious - how did you find this - code review or some tool help like
Sparse output or a compiler warning?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/