Re: swiotlb: Add missing __init annotations

From: Roland Dreier
Date: Fri Jan 02 2009 - 15:02:35 EST


> > @@ -186,7 +186,7 @@ static void swiotlb_print_info(unsigned long bytes)
> > * Statically reserve bounce buffer space and initialize bounce buffer data
> > * structures for the software IO TLB used to implement the DMA API.
> > */
> > -void __init
> > +void __init __weak
> > swiotlb_init_with_default_size(size_t default_size)
>
> This change looks unrealted to __init annotation described in the
> changelog. Was it intentional?

Yes, that was a thinko -- somehow while reading it I saw the __init
without __weak as being missing an annotation. Should I resend a fixed
patch?

- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/