Re: [PULL] cpumask tree

[Mike Travis]

Ingo Molnar wrote:
> * Mike Travis <travis@xxxxxxx> wrote:
> 
>> Ingo Molnar wrote:
>>> * Mike Travis <travis@xxxxxxx> wrote:
>>>
>>>>> Once we have figured out the CPU-hotplug lockdep splat (possibly due 
>>>>> to Mike's changes not yours) i'll send it to Linus. Thanks,
>>>>>
>>>>> 	Ingo
>>>> Thanks!  Am working on that now.
>>> do you suspect any of the commits? I'm bisecting it right now but if you 
>>> have bisected it already i wont repeat it.
>>>
>>> 	Ingo
>> I haven't done that yet, I'm just now getting your config to work pre-patches.
>>
>> But yes, I suspect one of the changes to use "work_on_cpu" -- this 
>> usually causes the 2nd call to get_online_cpus().
> 
> i suspect it's:
> 
> | commit 2d22bd5e74519854458ad372a89006e65f45e628
> | Author: Mike Travis <travis@xxxxxxx>
> | Date:   Wed Dec 31 18:08:46 2008 -0800
> |
> |     x86: cleanup remaining cpumask_t code in microcode_core.c
> 
> as the microcode is loaded during CPU onlining.
> 
> 	Ingo

I think you're right.  You need the coincidence of both writing to the
/sys/devices/system/cpu/cpuX/online file along with the cpu coming up
quickly enough to attempt to load the microcode before the write has
returned.  (Or something similar.)

Btw, I'm resending your "fix ia64" patch shortly.

Thanks,
Mike


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/