Re: [PATCH] firewire: cdev: fix documentation of FW_CDEV_IOC_GET_INFO

From: Stefan Richter
Date: Sat Jan 03 2009 - 19:53:11 EST


I wrote:
> The FW_CDEV_IOC_GET_INFO ioctl looks at client->device->config_rom, not
> at the local node's config ROM.
>
> We could fix the implementation or the documentation. I believe the way
> how it is currently implemented is more useful than the way how it is
> currently documented, hence let's change only the documentation.
...
> * struct fw_cdev_get_info - General purpose information ioctl
...
> * @rom: If non-zero, address of a buffer to be filled by a copy of the
> - * local node's configuration ROM
> + * device's configuration ROM

Of course libdc1394 uses the ABI already as implemented, not as documented.
--
Stefan Richter
-=====-==--= ---= --=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/