Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with!CONFIG_VIOPATH

[Stephen Rothwell]

Hi Milton,

On Sun, 4 Jan 2009 02:54:15 -0600 Milton Miller <miltonm@xxxxxxx> wrote:
>
> As VIOPATH is iSeries code and is only used by the iSeries code, the 
> requirment should be
> 
> depends on PPC_PSERIES || (PPC_ISERIES && VIOPATH)
> 
> except VIOPATH isn't selectable:
> 
> arch/powerpc/platforms/iseries/Kconfig:
> 
>   config VIOPATH
>          bool
>          depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
>          default y
> 
> so instead we should be adding
> 
> select VIOPATH if PPC_ISERIES
> 
> to SCSI_IBMVSCSI and just
> 
> select VIOPATH
> 
> to HVC_ISERIES as it depends on PPC_ISERIES
> 
> otherwise you have to enable one driver to get these other drivers.

You are completely correct.  We didn't have "select" when those drivers
were added (at least I was not aware of it) so they should all be changed
to select VIOPATH and the dependency in VIOPATH should be dropped.  This sort of thing is exactly what select is for.
-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature