Re: [PATCH] tracing/kmemtrace: normalize the raw tracer event tothe unified tracing API

From: Frederic Weisbecker
Date: Mon Jan 05 2009 - 18:51:06 EST


On Mon, Jan 05, 2009 at 11:48:56AM -0500, Steven Rostedt wrote:
>
> On Tue, 30 Dec 2008, Ingo Molnar wrote:
>
> >
> > * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> >
> > > kernel/trace/trace_kmemtrace.c | 345 ++++++++++++++++++++++++++++++++++++++++
> >
> > btw., i renamed this to kernel/trace/kmemtrace.c. Mentioning 'trace' twice
> > is enough already ;-)
>
> Should we rename all the kernel/trace/trace_(.*)\.c to kernel/trace/\1.c ?
>
> Although I do like the trace in the function name, because it groups them
> nicely together, and keeps ftrace.c and ring_buffer.c stand out from the
> rest.
>
> -- Steve
>

Or why not a subdirectory called "tracers" inside kernel/trace to store
the tracers files. This way, the core of tracing (ftrace.c/ring_buffer.c/trace_output.c/
/trace.c/trace_stat.c) can be found easily against the rest. Moreover, there is a risk that
the number of tracers will tend to increase by the time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/