Re: strncat() misuse (was: Re: dm_attr_{name,uuid}_show buffer overflow? (was: Re: linux-next: Tree for January 5))

From: Alasdair G Kergon
Date: Mon Jan 05 2009 - 21:17:58 EST


On Tue, Jan 06, 2009 at 01:27:59AM +0000, Alasdair G Kergon wrote:
> On Mon, Jan 05, 2009 at 11:18:38PM +0100, Geert Uytterhoeven wrote:
> > On Mon, 5 Jan 2009, Geert Uytterhoeven wrote:
> > > On Mon, 5 Jan 2009, Stephen Rothwell wrote:
> > > | strncat(buf, "\n", DM_NAME_LEN);
> > > | return strnlen(buf, DM_NAME_LEN);

I've edited the patch to use strcat and strlen.

http://git.kernel.org/?p=linux/kernel/git/agk/linux-2.6-dm.git;a=commit;h=911950f88bfd8a6747a1c6da5c5410641845bc64

Alasdair
--
agk@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/