Re: [PATCH 04/11] x86: cleanup remaining cpumask_t ops in smpboot code

[Jaswinder Singh Rajput]

Hi Mike,

On Tue, Jan 6, 2009 at 7:32 PM, Mike Travis <travis@xxxxxxx> wrote:
>
> I'll look closer but I had assumed that these masks would not be
> used for UP configurations (it did not get any compile errors
> with the allnoconfig).  In fact, any access to these masks for
> UP would be unnecessary since there are no callouts, the boot
> cpu is assumed initialized, and it has no siblings.  So the
> masks are specific to SMP.
>

If it is specific to SMP then:
CONFIG_X86_64 should be CONFIG_X86_64_SMP
CONFIG_X86_32 should be CONFIG_X86_32_SMP

I am in the process of cleaning smp.h and moving out non-smp from
smp.h as per Ingo's suggestion.

I am planning to move cpumask related things to asm/cpumask.h

Is this OK to you.

--
JSR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/