Re: 2.6.29 -mm merge plans

[Andrew Morton]

On Wed, 7 Jan 2009 14:05:51 +1100 Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:

> On Wednesday 07 January 2009 13:16:47 Andrew Morton wrote:
> > On Wed, 7 Jan 2009 13:06:44 +1100 Nick Piggin <nickpiggin@xxxxxxxxxxxx> 
> wrote:
> > > On Wednesday 07 January 2009 10:13:44 Andrew Morton wrote:
> > > > (cc added)
> > > >
> > > > On Tue, 6 Jan 2009 17:57:44 -0500
> > > >
> > > > Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> > > > > On Mon, Jan 05, 2009 at 12:43:00AM -0800, Andrew Morton wrote:
> > > > > > softirq-introduce-statistics-for-softirq.patch
> > > > > > proc-export-statistics-for-softirq-to-proc.patch
> > > > > > proc-update-document-for-proc-softirqs-and-proc-stat.patch
> > > > >
> > > > > Why is this in procfs?
> > > >
> > > > softirq stuff in /proc seems appropriate?  It's alongside
> > > > /proc/interrupts.  We could put it in /trendy-fs-of-the-day, but what
> > > > would it gain us?
> > >
> > > Haven't we kind of agreed to use sysfs for things like this? A few years
> > > too late to be raising objections now ;)
> > >
> > > One problem I have with sysfs is that it (the directory structure, rather
> > > than the sysfs code itself) really needs to be policed and maintained
> > > by a central and coherent place/person with taste. Otherwise people put
> > > their own random crap with their own random naming schemes and becomes
> > > a crazy mess.
> > >
> > > softirqs are not hardware but purely kernel subsystem construct, as such
> > > they probably go under /sys/kernel/. People unfortunately have already
> > > added random crap to the /sys/kernel/ root directory, but future
> > > additions really should go into a good subdirectory structure (putting it
> > > into the root directory is equivalent to ditching all subdirectories from
> > > /proc/sys/).
> >
> > All sounds like pointless wank^Wbikeshed painting to me.
> 
> Really? Our userspace ABI? You think it works bestter when there is as
> little thought as possible put into it and everybody just does what
> they feel is best?

If I thought that, I would say it.

> 
> > > /sys/kernel/softirq/*, I suggest.
> >
> > What would that *improve*?
> 
> It would be logically in the right place.

That's STILL not a *reason*.  Nobody has provded a reason.

Here's a reason: look in /proc.  It contains "interrupts", "irq",
"vmstat", "meminfo", etc.  All simple files which provide realtime view
of core kernel activity.  Which is precisely what /proc/softirq does!

So putting it in /proc/softirq is "logical", and yanking it out and
stuffing it in some random other place for reasons which nobody can
explain is illogical.

Plus the patch adds a summary line to the existing /proc/stat.  Which
is also logical.  Do we do that in debugfs too?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/