Re: Data corruption issue with splice() on 2.6.27.10

[Willy Tarreau]

On Wed, Jan 07, 2009 at 08:52:18PM +1100, Herbert Xu wrote:
> On Wed, Jan 07, 2009 at 07:38:59AM +0100, Willy Tarreau wrote:
> >
> > > Unfortunately, once the pipe is fed into sendpage we only use
> > > page reference counting to pin down the memory.  So as soon as
> > > sendpage returns we drop the ref count on the skb, thus freeing
> > > the memory in skb->head, which is yet to be transmitted.
> > 
> > So this means that anything relying on sendpage() is at risk ? What
> 
> No the bug is in the splice code.  sendfile() and other sendpage
> users are not affected.

but sendfile() now uses splice().

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/