Re: Deadlock after info soft-safe -> soft-unsafe lock order detected

From: Herbert Xu
Date: Wed Jan 07 2009 - 07:18:36 EST


Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> I'd be suspecting the percpu counter work in TCP?

This is the bogus lockdep output which is fixed by

commit ea319518ba3de282c13ae1cf4bf2215c5e03e67e
Author: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Date: Fri Dec 26 15:08:55 2008 +0100

locking, percpu counters: introduce separate lock classes

Impact: fix lockdep false positives

Classify percpu_counter instances similar to regular lock objects --
that is, per instantiation site.

The networking code has increased its use of percpu_counters, which
leads to false positives if they are treated as a single class.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

It was only pulled very recently despite the Dec 26 date.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/