Re: [PATCH -tip] x86: i8259.c fix style problems

[Ingo Molnar]

* Maciej W. Rozycki <macro@xxxxxxxxxxxxxx> wrote:

> > @@ -323,7 +323,7 @@ void init_8259A(int auto_eoi)
> >  	outb_pic(0x11, PIC_MASTER_CMD);	/* ICW1: select 8259A-1 init */
> >  
> >  	/* ICW2: 8259A-1 IR0-7 mapped to 0x30-0x37 on x86-64,
> > -	                       to 0x20-0x27 on i386 */
> > +	   to 0x20-0x27 on i386 */
> >  	outb_pic(IRQ0_VECTOR, PIC_MASTER_IMR);
> >  
> >  	/* 8259A-1 (the master) has a slave on IR2 */
> 
>  I think the original formatting is more readable; I would align the two 
> 'to's vertically even.  You can fix the comment to adhere to the Linux 
> coding standard though and the whitespace "problem" will vanish 
> automagically.

yep, this should be:

  	/*
	 * ICW2: 8259A-1 IR0-7 mapped to:
	 *
	 * - 0x20-0x27 on 32-bit
	 * - 0x30-0x37 on 64-bit
	 */

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/