Re: [RFC][PATCH 5/5] Merge code for single and multiple-instance mounts

[Christoph Hellwig]

On Wed, Jan 28, 2009 at 10:47:53PM -0800, Sukadev Bhattiprolu wrote:
> 
> From: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
> Date: Wed, 28 Jan 2009 19:11:15 -0800
> Subject: [RFC][PATCH 5/5] Merge code for single and multiple-instance mounts
> 
> new_pts_mount() (including the get_sb_nodev()), shares a lot of code
> with init_pts_mount(). The only difference between them is the 'test-super'
> function passed into sget().
> 
> Move the shared code into a new, common function, do_pts_mount() and
> remove new_pts_mount() and init_pts_mount() functions,

I would even merge init_pts_mount into devpts_get_sb, otherwise looks
good to me.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/