Re: [linux-pm] [PATCH 2/3] PCI PM: Let the core be more careful with respect to drivers using new framework

[Rafael J. Wysocki]

On Monday 02 February 2009, Nigel Cunningham wrote:
> Hi Rafael.
> 
> Just a couple of typos in the comment:
> 
> On Sun, 2009-02-01 at 22:33 +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@xxxxxxx>
> > 
> > Currently, the PM core always attempts to manage devices with drivers
> > that use the new PM framework.  In particular, it attempts to disable
> > the devices (which is unnecessary), to save their state (which may be
> > undesirable if the driver has done that already) and to put them into
> > low power states (again, this may be undesirable if the driver has
> > already put the device into a low power state).  That need not be
> > the right thing to do, so make the core be more careful in this
> > respect.
> > 
> > Generally, there are the following categories of devices to consider:
> > * bridge devices without drivers
> > * non-bridge devices without drivers
> > * bridge devices with drivers
> > * non-bridge devices with drivers
> > and each of them should be handled differently.
> > 
> > For bridge devices without drivers the PCI PM core will save their
> > state on suspend and restore it (early) during resume, after putting
> > them into D0 if necessary.  It will not attepmt to do anything else
> 
> s/attepmt/attempt/

OK

> > to these devices.
> > 
> > For non-bridge devices without drivers the PCI PM core will disable
> > them and save their state on suspend.  During resume, it will put
> > them into D0, if necessary, restore their state (early) and reenable
> > them.
> > 
> > For bridge devices without drivers the PCI PM core will only save
> 
> s/without/with/

Ouch, thanks.

> > their state on suspend if the driver hasn't done that already.
> > Still, the core will restore their state (early) during resume,
> > after putting them into D0, if necessary.
> > 
> > For non-bridge devices with drivers the PCI PM core will only save
> > their state on suspend if the driver hasn't done that already.  Also,
> > if the state of the device hasn't been saved by the driver, the core
> > will attempt to put the device into a low power state.  During
> > resume the core will restore the state of the device (early), after
> > putting it into D0, if necessary.
> > 
> > For all devices the core will disable wake-up during resume.
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> 
> I'm not pretending to understand the gory details of the code itself,
> and so don't want you to add a Reviewed-by or such like for me, thanks.

Thanks for the fixes, I'll resend the patch with updated changelog.

Best,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/