Re: [PATCH] Fix OOPS in mmap_region() when merging adjacent VM_LOCKEDfile segments

[Linus Torvalds]

On Mon, 2 Feb 2009, Mel Gorman wrote:
> 
> Lets say someone does the following
> 
> 1. mmap(PROT_READ, MAP_PRIVATE) on a hugetlbfs file
> 	VM_ACCOUNT is not set for hugetlbfs
> 	VM_NORESERVE is not set because MAP_NORESERVE was not there

But isn't this exactly the thing that we have that odd "accountable" flag 
for, and we do the whole

	if (!accountable)
		vm_flags |= VM_NORESERVE;

in mmap_region() for?

So VM_NORESERVE _will_ be set.

				Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/