Re: [PATCH 3/6] integrity: IMA display

[James Morris]

On Mon, 2 Feb 2009, Serge E. Hallyn wrote:

> >From dec581b116f16657db9b6f59b7e71f7a7026cd21 Mon Sep 17 00:00:00 2001
> From: Serge E. Hallyn <serue@xxxxxxxxxx>
> Date: Mon, 2 Feb 2009 15:07:33 -0800
> Subject: [PATCH 1/1] securityfs: fix long-broken securityfs_create_file comment
> 
> If there is an error creating a file through securityfs_create_file,
> NULL is not returned, rather the error is propagated.
> 
> Signed-off-by: Serge E. Hallyn <serue@xxxxxxxxxx>


Applied, thanks.

> ---
>  security/inode.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/security/inode.c b/security/inode.c
> index efea5a6..ae243dd 100644
> --- a/security/inode.c
> +++ b/security/inode.c
> @@ -205,12 +205,11 @@ static int create_by_name(const char *name, mode_t mode,
>   * This function returns a pointer to a dentry if it succeeds.  This
>   * pointer must be passed to the securityfs_remove() function when the file is
>   * to be removed (no automatic cleanup happens if your module is unloaded,
> - * you are responsible here).  If an error occurs, %NULL is returned.
> + * you are responsible here).  If an error occurs, the function will return
> + * the erorr value (via ERR_PTR).
>   *
>   * If securityfs is not enabled in the kernel, the value %-ENODEV is
> - * returned.  It is not wise to check for this value, but rather, check for
> - * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling
> - * code.
> + * returned.
>   */
>  struct dentry *securityfs_create_file(const char *name, mode_t mode,
>  				   struct dentry *parent, void *data,
> -- 
> 1.5.4.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/