Re: [PATCH 2/2] usb-serial: fix the aircable_init failure path

[Manuel Naranjo]

Acked-by: Naranjo Manuel Francisco <naranjo.manuel@xxxxxxxxx>
> The failure path of aircable_init is wrong, fix the order of (goto) labels.
>
> Signed-off-by: Dave Young <hidave.darkstar@xxxxxxxxx>
> ---
> drivers/usb/serial/aircable.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -uprN a/drivers/usb/serial/aircable.c b/drivers/usb/serial/aircable.c
> --- a/drivers/usb/serial/aircable.c	2009-02-01 13:12:35.000000000 +0800
> +++ b/drivers/usb/serial/aircable.c	2009-02-01 13:26:28.000000000 +0800
> @@ -621,9 +621,9 @@ static int __init aircable_init(void)
>  		goto failed_usb_register;
>  	return 0;
>  
> -failed_serial_register:
> -	usb_serial_deregister(&aircable_device);
>  failed_usb_register:
> +	usb_serial_deregister(&aircable_device);
> +failed_serial_register:
>  	return retval;
>  }
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/