Re: [PATCH] xen: fix 32-bit build resulting from mmu move

From: Ingo Molnar
Date: Tue Feb 03 2009 - 12:36:35 EST



* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Ingo Molnar wrote:
>> * Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
>>
>>
>>> Moving the mmu code from enlighten.c to mmu.c inadvertently broke the
>>> 32-bit build. Fix it.
>>>
>>> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
>>> ---
>>> arch/x86/xen/mmu.c | 37 +++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 37 insertions(+)
>>>
>>
>> that goes on top of the recent tip/x86/paravirt changes, right? No
>> objections, i'm wondering why my testing didnt find any build breakage.
>> Could you send me a .config that triggers the breakage?
>
> Any x86-32 + Xen build would hit it. +highmem+highpte would break a bit
> more.

i have a lot of successful builds with that pattern, that's why i asked for
a specific config from you that definitely triggers it - i'd like to
investigate how it escaped my testing procedures.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/