Re: [BUG] Suspend tries to suspend devices already in D3

[Frans Pop]

On Tuesday 03 February 2009, Frans Pop wrote:
> Looking at iwl-agn.c the cause could be that iwl_pci_suspend() depends
> on iwl_mac_stop() to call pci_save_state(). I added some debug
> statements in iwl_pci_suspend() that showed priv->is_open is false, so
> iwl_mac_stop does indeed *not* get called when the interface is down.

However, iwl_mac_stop() had been called when I ran ifdown just before
suspending the system:

# Here I run 'ifdown wlan0':
Feb  3 18:25:30 aragorn kernel: wlan0: deauthenticating by local choice (reason=3)
Feb  3 18:25:30 aragorn kernel: iwlagn: MAC is in deep sleep!
# The next debug statement is from iwl_mac_stop():
Feb  3 18:25:30 aragorn kernel: iwlagn FJP: state saved and device disabled
Feb  3 18:25:30 aragorn kernel: wlan0: deauthenticating by local choice (reason=3)
# Start of suspend:
Feb  3 18:25:54 aragorn kernel: PM: Syncing filesystems ... done.
Feb  3 18:25:54 aragorn kernel: Freezing user space processes ... (elapsed 0.00 seconds) done.
Feb  3 18:25:54 aragorn kernel: Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
Feb  3 18:25:54 aragorn kernel: Suspending console(s) (use no_console_suspend to debug)
Feb  3 18:25:54 aragorn kernel: sd 0:0:0:0: [sda] Synchronizing SCSI cache
Feb  3 18:25:54 aragorn kernel: sd 0:0:0:0: [sda] Stopping disk
Feb  3 18:25:54 aragorn kernel: ACPI handle has no context!
Feb  3 18:25:54 aragorn kernel: ACPI handle has no context!
Feb  3 18:25:54 aragorn kernel: sdhci-pci 0000:02:06.2: PME# disabled
Feb  3 18:25:54 aragorn kernel: ACPI handle has no context!
Feb  3 18:25:54 aragorn acpid: client 4081[0:0] has disconnected
Feb  3 18:25:54 aragorn kernel: ACPI handle has no context!
# The next debug statement is from iwl_pci_suspend() and shows priv->is_open is false:
Feb  3 18:25:54 aragorn kernel: iwlagn FJP: not calling iwl_mac_stop
Feb  3 18:25:54 aragorn kernel: ------------[ cut here ]------------
Feb  3 18:25:54 aragorn kernel: WARNING: at drivers/pci/pci-driver.c:375 pci_legacy_suspend+0xd4/0x11a()
Feb  3 18:25:54 aragorn kernel: Hardware name: HP Compaq 2510p Notebook PC
Feb  3 18:25:54 aragorn kernel: PCI PM: Device state not saved by iwl_pci_suspend+0x0/0x6a [iwlagn], state is D3hot
[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/