Re: [patch 2/6] epoll keyed wakeups v2 - introduce new *_poll()wakeup macros

[Linus Torvalds]

On Tue, 3 Feb 2009, Andrew Morton wrote:
> > 
> > Actually reading the comments helps :) It triggers an include-hell, if you 
> > make them inline. Since they're lockdep debug thingies, I think it's kinda 
> > wasted turn them into non-inline real functions, so they'd better remain 
> > macros IMO.
> 
> ho hum.  I think it'd be worth at least renaming the arguments to
> something less daft, for readability reasons.

Also, maybe we can make it an out-of-line thing rather than an inline?

Why not just make it

	extern void wake_up_nested[_poll](wait_queue_head_t *,
		[unsigned long pollflags, ] unsigned int nesting);

and then just move it out of a header file entirely by writing it as a 
real function in some *.c file that only gets compiled with 
DEBUG_LOCK_ALLOC.

Hmm? No include hell.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/