Re: [crash] af9005_usb_module_init(): BUG: unable to handle kernelpaging request at ff100000

[Luca Olivetti]

En/na Luca Olivetti ha escrit:
> En/na Ingo Molnar ha escrit:
> > * Daniel Walker <dwalker@xxxxxxxxxx> wrote:
> >
> > > On Tue, 2009-02-03 at 18:28 +0100, Ingo Molnar wrote:
> > > > FYI, -tip qa keeps triggering this bootup crash occasionally, ever 
> > > > since June 2008 when a DVB merge brought in this new driver:
> > > It looks like it could be a config problem.. The crash happens around 
> > > these two symbol "af9005_rc_keys", and "af9005_rc_keys_size" , and 
> > > they are both defined inside af9005-remote.c different from where the 
> > > init functions is lcoated .. af9005-remote.c needs a special config 
> > > CONFIG_DVB_USB_AF9005_REMOTE to get compiled which you have disabled..
> >
> > ok - but it shouldnt crash, obviously.
>
> Did you try my suggestion I sent the past December 26th?

The attached patch should be better (sorry it's bzipped, but thunderbird 
crashed three times when I tried to attach it raw), since it initializes 
the remote before calling usb_register.
Could you give it a try?

What I don't know is, if usb_register fails (so making module_init
fail), will module_exit be called nevertheless?
If not, those symbols would be kept and should be freed in module_init
in case usb_register fails.

Bye
--
Luca

Attachment: no_remote_crash.patch.bz2
Description: application/bzip