Re: [PATCH 3/4] kthreads: rework kthread_stop()

[Rusty Russell]

On Wednesday 04 February 2009 15:40:06 Eric W. Biederman wrote:
> static struct kthread *to_kthread(struct task_struct *tsk)
> {
> 	void *stack = task_stack_page(tsk);
> 	return (struct kthread *)(stack + kthread_offset);
>         
> }
...
> It would remove the test and be simple and obviously correct.

Clever? Sure.  Neat? Yes.

But you are using a definition of obvious with which I was not previously
familiar :)

Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/