Re: [PATCH 1/4] ptrace: kill __ptrace_detach(), fix ->exit_state check

[Roland McGrath]

> Move the code from __ptrace_detach() to its single caller and kill this
> helper.
> 
> Also, fix the ->exit_state check, we shouldn't wake up EXIT_DEAD tasks.

Yes, though that is probably impossible anyway.  Perhaps in a de_thread
race, but probably harmlessly does nothing.  Anyway, certainly fine to
change the test to match all others of the same ilk.

> Actually, I think task_is_stopped_or_traced() makes more sense, but this
> needs another patch.

Agreed.  It is one of those nasty cases where the old semantics are
"clearly" wrong, but it's very hard not to worry that some obscure
combination of circumstances means that some common-enough case actually
depends on the "wrong" wakeup.

> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Acked-by: Roland McGrath <roland@xxxxxxxxxx>


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/