Re: [PATCH 2/4] reparent_thread: fix the "is it traced" check

From: Roland McGrath
Date: Wed Feb 04 2009 - 21:17:00 EST


> reparent_thread() uses ptrace_reparented() to check whether this thread
> is ptraced, in that case we should not notify the new parent.

I think at some point in the past, ptracedness could sometimes transfer to
the new parent, so this made sense then (before it had that name).

> But ptrace_reparented() is not exactly correct when the reparented thread
> is traced by /sbin/init, because forget_original_parent() has already
> changed ->real_parent.

Heh. Ok. I think the !p->ptrace check is fine.

Acked-by: Roland McGrath <roland@xxxxxxxxxx>


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/