Re: [PATCH 2/2 v4] softlockup: check all tasks in hung_task

From: Ingo Molnar
Date: Thu Feb 05 2009 - 09:35:38 EST



* Mandeep Singh Baines <msb@xxxxxxxxxx> wrote:

> The batch_count controls the preemptibility of hung_task. While it might
> not make sense to expose the value to user-space, we may want to use a
> different value for the PREEMPT config (not sure what the specific values
> should be):
>
> #if defined(CONFIG_PREEMPT) && !defined(CONFIG_PREEMPT_RCU)
> static const int check_count_batching = 256;
> #else
> static const int check_count_batching = 2048;
> #endif

That really is not worth it - and such #ifdefs always look ugly and split
testing as well.

I've applied your patch to tip:core/softlockup, thanks Mandeep!

Ingo

------------->