Re: [PATCH 3/4] ptrace: reintroduce __ptrace_detach() as a calleeof ptrace_exit()

[Oleg Nesterov]

On 02/04, Roland McGrath wrote:
>
> > No functional changes, preparation for the next patch.
> > 
> > Move the "should we release this child" logic into the separate handler,
> > __ptrace_detach().
> 
> My inclination is to use bool in new code for true/false return values,
> but I don't really care.
> 
> Please canonicalize the comment formatting for your new comments.
> 
> The preserved comment no longer makes sense, there is no "dead list" in
> that function.  Make it a coherent comment at the top that explains the
> return value.

OK, I'll send the cleanup patch.

> Given its content, this function now better belongs in ptrace.c, I think.

I don't completely agree... This helper imho has nothing to do with
ptracing, except it does __ptrace_unlink(). But OK, I will move it
if you prefer. In that case we should export task_detached().

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/