Re: [PATCH 1/2] show hypervisor information on cpuinfo

[Anthony Liguori]

Ingo Molnar wrote:
> * Glauber Costa <glommer@xxxxxxxxxx> wrote:
>
>   
> > +char * __cpuinit hypervisor_str(struct cpuinfo_x86 *c)
> > +{
> > +	if (c->x86_hyper_vendor == X86_HYPER_VENDOR_VMWARE)
> > +		return "VMWare";
> > +	else
> > +		return "none";
> > +}
> >     
>
> i'd suggest these variants instead:
>
>  virtualization:	native kernel
>   

I don't think "native kernel" really ports well to other architectures 
(like s390 or PPC) that always have hypervisors present in some form.  I 
think "none" makes more sense in the case of bare metal x86.

Regards,

Anthony Liguori

>  virtualization:	KVM guest
>  virtualization:	VMWare guest
>  virtualization:	Linux guest
>
> 	Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/