Re: PATCH: Allow user to force 'tsc' to be treated as stable.

[Frans Pop]

Ben Greear wrote:
> +       if (force_tsc_stable && (strcmp(cs->name, "tsc") == 0))
> +               printk(KERN_WARNING "Forcing tsc to be treated as stable due to force_tsc_stable=1\n");
> +       else { 
> +               printk(KERN_WARNING "  This clock is no longer valid for WATCHDOG or HIGH-RES.\n");
> +               if (strcmp(cs->name, "tsc") == 0)
> +                       printk(KERN_WARNING "  Use force_tsc_stable=1 to override.\n");

Do we really want to be so verbose?

Loads of users get these messages (I get it on both my laptops) and IIUC
the workaround is only valid for a very limited group of users.

I'd suggest dropping the "else" branch. It seems inadvisable to encourage
workarounds that may not be valid (or even safe).

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/