Re: [PATCH tip 1/2] ring_buffer: remove unused flags parameter

[Steven Rostedt]

On Thu, 5 Feb 2009, Frederic Weisbecker wrote:
> >  
> > -	event = ring_buffer_lock_reserve(tr->buffer, sizeof(*entry),
> > -					 &irq_flags);
> > +	event = ring_buffer_lock_reserve(tr->buffer, sizeof(*entry));
> >  	if (!event)
> >  		goto out;
> >  	entry	= ring_buffer_event_data(event);
> >  	tracing_generic_entry_update(&entry->ent, 0, 0);
> >  	entry->ent.type = TRACE_POWER;
> >  	entry->state_data = *it;
> > -	ring_buffer_unlock_commit(tr->buffer, event, irq_flags);
> > +	ring_buffer_unlock_commit(tr->buffer, event);
> >  
> >  	trace_wake_up();
> >  
> > -- 
> > 1.6.0.6
> > 
> 
> 
> I don't what Steven planned (or not) with this flag.
> If it's not related to his lockless ring buffer project or anything, this
> cleanup is welcome.

The irq_flags is legacy from the original implementation. Arnaldo is just 
going through my todo list (without even me telling him what it is ;-)

Now only if I can get Arnaldo to do the TODO list my wife gives me ;-)

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/