Re: [-mm patch] Show memcg information during OOM (v3)

[Li Zefan]

Li Zefan wrote:
>> +	mem_cgrp = memcg->css.cgroup;
>> +	task_cgrp = mem_cgroup_from_task(p)->css.cgroup;
> 
> I just noticed since v2, task's cgroup is also printed. Then 2 issues here:
> 
> 1. this is better: task_cgrp = task_subsys_state(p, mem_cgroup_subsys_id);

sorry, s/task_subsys_state/task_cgroup/

> 2. getting cgroup from a task should be protected by task_lock or rcu_read_lock,
>    so we can put the above statement inside rcu_read_lock below.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/