[linux-next][PATCH] revert headers_check fix: ia64, fpu.h

From: KOSAKI Motohiro
Date: Fri Feb 06 2009 - 03:19:22 EST


> diff --git a/arch/ia64/include/asm/fpu.h b/arch/ia64/include/asm/fpu.h
> index 3859558..b6395ad 100644
> --- a/arch/ia64/include/asm/fpu.h
> +++ b/arch/ia64/include/asm/fpu.h
> @@ -6,7 +6,7 @@
> * David Mosberger-Tang <davidm@xxxxxxxxxx>
> */
>
> -#include <asm/types.h>
> +#include <linux/types.h>

this change break ia64 build perfectly.
this patch seems don't tested at all.

Ingo, I hope you ask patch author how to test posted patch ;-)

==
Subject: [PATCH] revert headers_check fix: ia64, fpu.h

commit fa9ea6c7abd94482ecd84e130676b6a1b3e61c2c break ia64 build perfectly.
it because ia64 has following include file dependency.

entry.S
-> asm/processor.h
-> asm/ptrace.h
-> asm/fpu.h

Then, above commit introduce below dependency.

entry.S
-> asm/processor.h
-> asm/ptrace.h
-> asm/fpu.h
-> linux/types.h
-> linux/posix_types.h
-> linux/stddef.h

Then, assembler can't intepret following statement in stddef.h

enum {
false = 0,
true = 1
};


Therefore, >100 line tons error was outputed.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Cc: Jaswinder Singh Rajput <jaswinder@xxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: linux-next <linux-next@xxxxxxxxxxxxxxx>
Cc: linux-ia64 <linux-ia64@xxxxxxxxxxxxxxx>
Cc: Tony Luck <tony.luck@xxxxxxxxx>
---
arch/ia64/include/asm/fpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/arch/ia64/include/asm/fpu.h
===================================================================
--- a/arch/ia64/include/asm/fpu.h
+++ b/arch/ia64/include/asm/fpu.h
@@ -6,7 +6,7 @@
* David Mosberger-Tang <davidm@xxxxxxxxxx>
*/

-#include <linux/types.h>
+#include <asm/types.h>

/* floating point status register: */
#define FPSR_TRAP_VD (1 << 0) /* invalid op trap disabled */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/