Re: [PATCH 35 of 36] x86: make pgd/pud/pmd/pte_none consistent

[Ian Campbell]

On Fri, 2009-02-06 at 15:29 +0000, Ian Campbell wrote:
> On Thu, 2009-02-05 at 11:31 -0800, Jeremy Fitzhardinge wrote:
> > The _none test is done differently for every level of the pagetable.
> > Standardize them by:
> > 
> >  1: Use the native_X_val to extract the raw entry, with no need to go
> >     via paravirt_ops, diff -r 1d0646d0d319 arch/x86/include/asm/pgtable.h, and
> >  2: Compare with 0 rather than using a boolean !, since they are actually values
> >     and not booleans.
> 
> In a 32 bit Xen guest this one causes
> 
>         [    8.354898] 1 multicall(s) failed: cpu 1

Spoke too soon, it's not as 100% reliably reproducing as I thought which
confused my bisection attempt. Will try and locate the real culprit...

Ian.

-- 
Ian Campbell

For a man to truly understand rejection, he must first be ignored by a cat.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/