Re: [PATCH 001/001] usbserial: New mobile broadband modems to besupported through option module

[Greg KH]

On Fri, Feb 06, 2009 at 12:58:39PM +0100, Oliver Neukum wrote:
> Am Friday 06 February 2009 12:29:06 schrieb Dirk DeSchepper:
> > From: Dirk De Schepper <ddeschepper@xxxxxxxx>
> > 
> > Patch for option.c, based on kernel v2.6.28.3
> > - New Novatel and Dell mobile broadband modem products added
> > - Dell pid variables used in stead of numerical PIDs for known products
> 
> This is not really an advantage. You usually get the nummeric IDs
> just fine from lsusb. And you could easily see the nummeric order of entries.
> These symbolic names do not appear in code, just in the macros
> where their meaning is clear. You introduce a useless level of indirection.

No, it's fine, we can use all of the descriptive information that we can
get at times.  So changing the defines from a generic one, to a specific
one to match the device type, only helps out in the end.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/