Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Mike Frysinger]

On Fri, Feb 6, 2009 at 14:26, Felipe Balbi wrote:
> On Fri, Feb 06, 2009 at 02:24:27PM -0500, Mike Frysinger wrote:
>> On Fri, Feb 6, 2009 at 14:15, Felipe Balbi wrote:
>> > On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
>> >> From: Mike Frysinger <vapier.adi@xxxxxxxxx>
>> >
>> > I'd like to get a patch body here.
>> >
>> >> Signed-off-by: Mike Frysinger <vapier.adi@xxxxxxxxx>
>> >> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>
>> >> ---
>> >>  drivers/usb/musb/blackfin.c |    9 +++++----
>> >>  1 files changed, 5 insertions(+), 4 deletions(-)
>> >>
>> >> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
>> >> index 7861348..0ebb19d 100644
>> >> --- a/drivers/usb/musb/blackfin.c
>> >> +++ b/drivers/usb/musb/blackfin.c
>> >> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
>> >>  void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
>> >>  {
>> >>       void __iomem *fifo = hw_ep->fifo;
>> >> +
>> >> +#ifdef CONFIG_BF52x
>> >>       u8 epnum = hw_ep->epnum;
>> >>       u16 dma_reg = 0;
>> >
>> > Is this patch avoiding a warning about these variables being unused ?
>> >
>> > Would be nice to get this info to the patch body ;-)
>>
>> the subject already says that
>
> the subject says:
>
> "tweak musb_read_fifo() to avoid unused warnings"
>
> it doesn't specify where are the warnings.

i dont think it really adds anything to explicitly mention every
variable that triggers an unused warning.  but if we look at the code
that changed, it's easy to see that it's epnum and dma_reg.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/