Re: [PATCH] Soekris net5501 board support code

[Alessandro Zummo]

On Fri, 6 Feb 2009 15:21:21 -0800
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > +	rombase = ioremap(0xffff0000, 0xffff);
> > +	if (!rombase)
> > +		return 0;  
> 
> Is it appropriate to silently "succeed" if the ioremap() failed?

 maybe not.. I'll add a printk. ty.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/