Re: [PATCH] olpc: fix model detection without OFW

[Andres Salomon]

As discussed on IRC, this has the Dilinger Seal Of Approval (tm).

Acked-by: Andres Salomon <dilinger@xxxxxxxxxx>



On Fri, 13 Feb 2009 20:56:18 -0500
Chris Ball <cjb@xxxxxxxxxx> wrote:

> Harvey's endianness patch (e51a1ac2dfca9ad869471e88f828281db7e810c0)
> breaks model comparison on OLPC; the value 0xc2 needs to be scaled
> up by olpc_board().  The pre-patch version was wrong, but accidentally
> worked anyway (big-endian 0xc2 is big enough to satisfy all other
> board revisions, but little endian 0xc2 is not).
> 
> Signed-off-by: Chris Ball <cjb@xxxxxxxxxx>
> ---
>  arch/x86/kernel/olpc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/olpc.c b/arch/x86/kernel/olpc.c
> index 7a13fac..4006c52 100644
> --- a/arch/x86/kernel/olpc.c
> +++ b/arch/x86/kernel/olpc.c
> @@ -203,7 +203,7 @@ static void __init platform_detect(void)
>  static void __init platform_detect(void)
>  {
>  	/* stopgap until OFW support is added to the kernel */
> -	olpc_platform_info.boardrev = 0xc2;
> +	olpc_platform_info.boardrev = olpc_board(0xc2);
>  }
>  #endif
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/