Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/kallsyms.c

[Stefan Richter]

On 2/15/2009 7:47 PM, Sam Ravnborg wrote:
> On Mon, Feb 16, 2009 at 12:04:36AM +0530, Manish Katiyar wrote:
>> Hi Ingo,
>> 
>> I used your code-quality script to do cleanup in kernel/kallsyms.c.
>> Below patch removes errors generated by checkpatch.pl.
> When doing so use checkpatch only as a hint generator and do
> not concentrate only on the warnings/errors generated by checkpatch.
> 
> Your patch is an improvement but please fix the remaining issues.

Furthermore, the changelog is bad (non-exiting in fact).

The fact that the issues where discovered using checkpatch is absolutely
uninteresting.  The changelog should describe /what/ is fixed, e.g.
whitespace, maybe other things.  (In case of nontrivial changes the log
may also need to explain not only the /what but also the /how/, but this
does not apply to patches like this one.)
-- 
Stefan Richter
-=====-==--= --=- =----
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/