Re: RT scheduling and a way to make a process hang, unkillable

[Peter Zijlstra]

On Mon, 2009-02-16 at 18:44 +0530, Dhaval Giani wrote:
>  (This is not a good day!)

Monday strikes again ;-)

> @@ -572,6 +572,9 @@ static int set_user(struct cred *new)
>  	if (!new_user)
>  		return -EAGAIN;

So here we just allocated new_user and made sure we didn't fail that
allocation.

> +	if (!task_can_switch_user(new->uid, current))
> +		return -EAGAIN;

And here you bail, without freeing new_user. The idea was to do this
check before alloc_uid().

>  	if (atomic_read(&new_user->processes) >=
>  				current->signal->rlim[RLIMIT_NPROC].rlim_cur &&
>  			new_user != INIT_USER) {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/