Re: [PATCH] Fix vde network backend in user mode linux

From: AmÃrico Wang
Date: Mon Feb 16 2009 - 08:21:28 EST


On Mon, Feb 16, 2009 at 01:51:35PM +0100, Jiri Kosina wrote:
>On Mon, 16 Feb 2009, AmÃrico Wang wrote:
>
>> >[ doesn't seem to be picked up by anyone into current -next nor -mmotm,
>> > but isn't appropriate for trivial; adding akpm to cc ]
>> >> * Replace kmalloc() with uml_kmalloc()
>> >> (fix build failure)
>> Weird... I sent a patch for this several months ago! I thought Jeff had
>> already taken it... No?
>
>I am not sure whether this has been fixed in another way, but current
>linux-next still has
>
> void vde_init_libstuff(struct vde_data *vpri, struct vde_init *init)
> {
> struct vde_open_args *args;
>
> vpri->args = kmalloc(sizeof(struct vde_open_args), UM_GFP_KERNEL);
>
>so the patch hasn't been at least applied in the form it has been
>submitted.

Hmmm, no, I just checked, but more than half a year ago, we already
did this: http://lkml.org/lkml/2008/7/23/142

It looks like Jeff is too busy to maintain UML patches recently...

Andrew, could you please take UML patches for us? Recently I also
saw some uml patches but no one took them (at least I don't know).

If Andrew can't do this, I would like to take those patches to send
to Linus, if others don't have objections. Andrew?

--
"Against stupidity, the gods themselves, contend in vain."

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/