Re: [PATCH 3/4] generic-smp: properly allocate the cpumasks
From: Rusty Russell
Date: Mon Feb 16 2009 - 18:17:20 EST
On Tuesday 17 February 2009 03:08:50 Peter Zijlstra wrote:
> Its not deemed proper to have full cpumasks in data anymore, we have to
> dynamically allocate them based on runtime determined dimensions of the
> machine in question.
Wow, thanks.
But FYI I would have been happy with allocating them for each possible CPU,
rather than doing the hotplug callback thing.
If you really *can* have 4096 CPUS, I'm not so upset about spending 2M; it's
when you've got 2 CPUs and the distro has set CONFIG_NR_CPUS=4096 that I
care about.
I'm not saying to fix it, I'm just saying you went beyond the call of duty.
Kudos,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/