Re: [PATCH 1/2] libata-sff: fix 32-bit PIO ATAPI regression

[Jeff Garzik]

Sergei Shtylyov wrote:
> Commit 871af1210f13966ab911ed2166e4ab2ce775b99d (libata: Add 32bit PIO support)
> has caused all kinds of errors on the ATAPI devices, so it has been empirically
> proven that one shouldn't try to read/write an extra data word when a device is
> not expecting it already. "Don't do it then"; however, still use a chance to do
> 32-bit read/write one last time when there are exactly 3 trailing bytes.
>
> Oh, and stop pointlessly swapping the bytes to and fro on big-endian machines
> by using io*_rep() accessors which shouldn't byte-swap.
>
> This patch should fix the kernel.org bug #12609.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
>
> ---
> Added the comments and signoff.
> The patch is against the recent Linus' tree.
> It's a hopefully better replacement for Hugh Dickins most recent patch
> (http://marc.info/?l=linux-ide&m=123352294619281)...

applied, much appreciated!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/