Re: [PATCH 4/7] x86: memtest: adapt log messages

From: Andreas Herrmann
Date: Tue Feb 17 2009 - 05:30:20 EST


On Fri, Feb 13, 2009 at 05:53:02PM +0100, Ingo Molnar wrote:
>
> * Andreas Herrmann <andreas.herrmann3@xxxxxxx> wrote:
>
> > +#ifdef CONFIG_X86_64
> > + printk(KERN_CONT "\n %010llx - %010llx pattern %016llx",
> > + t_start, t_start + t_size, cpu_to_be64(pattern));
> > +#else
> > + printk(KERN_CONT "\n %010llx - %010llx pattern %08x",
> > + t_start, t_start + t_size, cpu_to_be32(pattern));
> > +#endif
>
> hm, is there really no cleaner way to do this?

There is -- but only if 32-bit-code is changed to use u64 for the test
pattern.


Andreas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/