Re: [PATCH 04/15] ftrace: break up ftrace_match_records intosmaller components

[Ingo Molnar]

* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> +static void ftrace_match_records(char *buff, int len, int enable)
> +{
> +	char *search;
> +	struct ftrace_page *pg;
> +	struct dyn_ftrace *rec;
> +	int type;
> +	unsigned long flag = enable ? FTRACE_FL_FILTER : FTRACE_FL_NOTRACE;
> +	unsigned search_len;
> +	int not;

Small style nit, the above looks better as:

> +	unsigned int search_len;
> +	struct ftrace_page *pg;
> +	struct dyn_ftrace *rec;
> +	unsigned long flag;
> +	char *search;
> +	int type;
> +	int not;
> +
> +	flag = enable ? FTRACE_FL_FILTER : FTRACE_FL_NOTRACE;

and this is what we do in other places of the tracing code.

(Also note the change of 'unsigned search_len' to 'unsigned int 
search_len'.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/