Re: [PATCH 4/6] ide: add ->dma_expiry method and remove ->dma_exec_cmdone

[Sergei Shtylyov]

Bartlomiej Zolnierkiewicz wrote:

> > Hello.

> > Bartlomiej Zolnierkiewicz wrote:

> > > > Bartlomiej Zolnierkiewicz wrote:

> > > > > * Rename dma_timer_expiry() to ide_dma_sff_expiry() and export it.

> > > > > * Add ->dma_expiry method

> > > >   This name doesn't seem to make much sense. Why not leave it dma_timer_expiry?

> > > Well, the name matches with hwif->expiry one + the downside of leaving it at
> > > dma_timer_expiry is a need to reformat all struct ide_dma_ops instances...

> On the 2nd look it doesn't seem to be a problem (I must have been looking at
> some odd case previously) -- I'll fix it up later.

   I vote for timer_expiry().

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/