Re: [Bug #12650] Strange load average and ksoftirqd behavior with2.6.29-rc2-git1

[Damien Wyart]

Hello Paul,

> > There's no strong reason - we've been back and forth about RCU in
> > the dynticks code. Mind sending a test patch for Damien to try?

> But of course!  ;-)

With this patch, the problem goes away and system activity seems normal,
both on the P4 with high load and on the recent laptop.

Btw, could you explain briefly why, without this patch, a kernel
enabling classical RCU doesn't show the ksoftirqd problem at all?


Damien

> The following patch removes the call to rcu_pending() and
> rcu_check_callbacks() from the x86 32-bit idle loop in order to
> reduce the softirq load on idle systems.

> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> ---

>  process_32.c |    3 ---
>  1 file changed, 3 deletions(-)

> diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c
> index a546f55..bd4da2a 100644
> --- a/arch/x86/kernel/process_32.c
> +++ b/arch/x86/kernel/process_32.c
> @@ -104,9 +104,6 @@ void cpu_idle(void)
>  			check_pgt_cache();
>  			rmb();

> -			if (rcu_pending(cpu))
> -				rcu_check_callbacks(cpu, 0);
> -
>  			if (cpu_is_offline(cpu))
>  				play_dead();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/