Re: irq-disabled vs vmap vs text_poke

From: Steven Rostedt
Date: Tue Feb 17 2009 - 12:49:06 EST



On Tue, 17 Feb 2009, Mathieu Desnoyers wrote:

> * Steven Rostedt (rostedt@xxxxxxxxxxx) wrote:
> >
> > On Tue, 17 Feb 2009, Mathieu Desnoyers wrote:
> > > >
> > >
> > > Anyway dynamic ftrace only need to do code patching at early boot,
> > > right? Or do you need also to patch the call sites a bit later too ?
> > > Because there is a text_poke_early for that purpose : modifying code
> > > when it is still writable.
> >
> > It modifies the code both at early boot up, and when it is enabled later
> > on at run time.
> >
> > -- Steve
> >
>
> OK, so without text_poke, how does it deal with kernel with text pages
> marked read-only after boot ?

Actually, we cheat. If DYNAMIC_FTRACE is configured in, we do not set the
text sections to read only. But if this needs to be fixed, we can easily
change it so that before we do the convesion, we set all text back to
write and after the conversion we set it back to read. The conversion
itself is done via stop_machine, so we do not need to worry about other
things going on.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/